Add dependencies on morph feature for bevy_pbr, fixes #21528#21529
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Oct 14, 2025
Merged
Add dependencies on morph feature for bevy_pbr, fixes #21528#21529alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit dependencies on the "morph" feature for bevy_mesh and bevy_render in bevy_pbr to fix a build issue when not using default features.
- Adds "morph" and "bevy_mikktspace" features to bevy_mesh dependency
- Adds "morph" feature to bevy_render dependency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alice-i-cecile
approved these changes
Oct 13, 2025
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
S-Needs-Review
Member
|
CI is complaining about formatting, but the core idea is good so I've approved. You'll need to fix that before we can merge. |
atlv24
approved these changes
Oct 14, 2025
Contributor
atlv24
left a comment
atlv24
left a comment
There was a problem hiding this comment.
Thanks, note that this is not a problem present on 0.17 as my morph pr landed in 0.18
alice-i-cecile
added
S-Ready-For-Final-Review
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
bevyengine#21529) # Objective Fixes bevyengine#21528 causing the main branch to not build when not using default features ## Solution Added explicit dependencies on morph feature for bevy_mesh and bevy_render for bevy_pbr ## Testing Now builds successfully on my machine using > cargo build --no-default-features --features std,x11,bevy_winit,bevy_state,bevy_window,bevy_pbr,bevy_sprite,bevy_text,bevy_core_pipeline,bevy_picking,bevy_animation,png,zstd_rust,tonemapping_luts,ktx2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #21528 causing the main branch to not build when not using default features
Solution
Added explicit dependencies on morph feature for bevy_mesh and bevy_render for bevy_pbr
Testing
Now builds successfully on my machine using